Asset library fails to resolve file system paths correctly #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e is optional, but still happens by default
…o prepend request web path, so the relative path can be resolved correctly, since they are reading files of the file system
|
fixes pyrocms/pyrocms#4863 |
|
As assetic is getting pulled out and the asset class get's cleaned up - I've fixed this in the 1.7 branch based on what you've provided me here. Thanks! Sorry I couldn't get this in sooner - I really wanted to let the asset class sit still until it could be given more attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue with resolving asset file system paths correctly.