Use custom interval configuration

[mmachatschek]

No description provided.

[sandervanhooft]

Thanks for taking a shot at this @mmachatschek , much appreciated.

You're now essentially combining the behaviour of three Interval generators in one. I think it would be better to split them up in three simple classes, all implementing the same Interval(Generator)Contract.

Then in the plan config, you could swap the generator out depending on your use case. The current interval config key can be used to pass in parameter values. As you suggested, either a string or an array.

What do you think?

[mmachatschek]

@sandervanhooft sounds great! I'll update the PR and bump you as soon as you can have another look!

[mmachatschek]

@sandervanhooft the PR now contains extendable Interval::class's

[mmachatschek]

One more issue appeared upon going threw this.
What should happen when you reset the cycle? With a fixed interval now you will have problems with the first cycle as its reset to the day of creation of the subscription.

See Subscription::restartCycleWithModifications()

[sandervanhooft]

Subscription::restartCycleWithModifications() is resetting to the start of the cycle cycle_started_at, not the start of the subscription created_at.

[hadjedjvincent]

@mmachatschek you have a typo on IntervalConfigrationInvalidException class name, should be IntervalConfigurationInvalidException 😄

[mmachatschek]

@sandervanhooft I'm closing this for now due to lack of time. If anyone else wants to pick up parts from this PR, feel free!