This repository has been archived by the owner on Feb 2, 2022. It is now read-only.
Add update command #324
Closed
Add update command #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandervanhooft
suggested changes
Jun 15, 2021
|
|
||
| $this->comment('Import Mollie payments, first payment actions'); | ||
| $paymentsIds->each(function ($payment) use ($mollieApi) { | ||
| $molliePaymentData = $mollieApi->payments()->get($payment); |
There was a problem hiding this comment.
Mollie will throttle this if too many requests come in at once, causing a Mollie ApiException. Need to come up with a more robust solution, how about queued jobs with a rate limiter?
There was a problem hiding this comment.
Since the app is backwards compatible it can run in the background, no need to wait for the queue to finish.
There was a problem hiding this comment.
But if the app doesn't use queue?
There was a problem hiding this comment.
this can even work with the table queue driver. I don't think there's a way around it, other than introducing sleep(1), which is messy here 😜
|
I'm holding off on the update command until after release. Will close this for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.