[2.x] Add the ability to get the paddle error #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heya, thanks for your PR. Could you show a before/after example of this? Maybe through a screenshot of the Ignition error page? |
driesvints
changed the title
|
Yeah sure thing Before A general exception with an invalid key: 
An exception due to validation: 
After A general exception with an invalid key: 
An exception due to validation: 
By catching the exception and calling 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The aim of this pull request to make it easier to get the paddle error response. The
Cashiercurrently throws an exception when Paddle returns an error, but it only provides theerror.detail.There is also a
$messagevariable which is set but never used. I've therefore updated thePaddleExceptionto use that custom$messagevariable and added a method for getting the Paddle error response.One of the main use cases behind this PR, is being able to get the validation messages and formatting them into a readable format for the user.