Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.x] Always end trial when subscription is cancelled #1465

Merged
merged 3 commits into from Oct 28, 2022

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Oct 28, 2022

This change in behavior will cause subscriptions to always skip their trial once they're ended/cancelled. It's more in line on how Stripe works/behaves. Once a subscription is cancelled after this change it will not be active anymore when there's still an ongoing trial. This also better accommodates the expected behavior when cancelling subscriptions from the Stripe Dashboard "immediately" which was a long outstanding weird behavior when the subscription was still on trial.

I thought about this long and hard and I think this is the best choice going forward. I considered adding an option to opt-in to the old behavior but I believe it makes most sense that a subscription isn't active anymore after it's considered cancelled or ended.

Targetting the next major version because this is a breaking change.

@driesvints driesvints changed the title Always end trial when subscription is cancelled [14.x] Always end trial when subscription is cancelled Oct 28, 2022
@driesvints driesvints changed the title [14.x] Always end trial when subscription is cancelled [15.x] Always end trial when subscription is cancelled Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants