[15.x] Always end trial when subscription is cancelled #1465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in behavior will cause subscriptions to always skip their trial once they're ended/cancelled. It's more in line on how Stripe works/behaves. Once a subscription is cancelled after this change it will not be active anymore when there's still an ongoing trial. This also better accommodates the expected behavior when cancelling subscriptions from the Stripe Dashboard "immediately" which was a long outstanding weird behavior when the subscription was still on trial.
I thought about this long and hard and I think this is the best choice going forward. I considered adding an option to opt-in to the old behavior but I believe it makes most sense that a subscription isn't active anymore after it's considered cancelled or ended.
Targetting the next major version because this is a breaking change.