Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.x] Add ability to set a description on "one-off" charge checkouts #1525

Merged
merged 3 commits into from
Apr 13, 2023
Merged

[14.x] Add ability to set a description on "one-off" charge checkouts #1525

merged 3 commits into from
Apr 13, 2023

Conversation

AmrAb-05
Copy link
Contributor

Right now its not possible to set a description for checkout sessions created with for example

$request->user()->checkoutCharge(1200, 'T-Shirt', 5);

@driesvints
Copy link
Member

Maybe we should rename that to $productData and merge the array with the current one so you can set all options: https://stripe.com/docs/api/checkout/sessions/create#create_checkout_session-line_items-price_data-product_data

@taylorotwell taylorotwell marked this pull request as draft April 11, 2023 17:18
AmrAb-05
AmrAb-05 commented Apr 11, 2023
View reviewed changes
Copy link
Contributor Author

@AmrAb-05 AmrAb-05 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this look?

@AmrAb-05 AmrAb-05 marked this pull request as ready for review April 11, 2023 18:19
@driesvints driesvints changed the title Add ability to set a description on "one-off" charge checkouts [14.x] Add ability to set a description on "one-off" charge checkouts Apr 13, 2023
@taylorotwell taylorotwell merged commit afc4fd2 into laravel:14.x Apr 13, 2023
6 checks passed
@driesvints driesvints mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AmrAb-05 @driesvints @taylorotwell