[10.x] Remove extra sign off from ConfirmPayment notification

[ralphmorris]

Just tested the confirm payment notification. Works great but I end up with two "sign offs" as one is being added in the default notification template and the other in ConfirmPayment.

For example my ConfirmPayment sign off was:

"Thanks,

App Name

Regards,
App Name"

I have removed line 66 and 67 from ConfirmPayment so the sign off only exists in the default notification template. Although I quite like the way it says "Thanks" as it is asking the user for an extra action. Maybe it could just say "Thanks", rather than "Thanks, app.name, Regards app.name"?

Of course, ignore this if it is the way it is intended :)

[driesvints]

Hmm, very odd that I never noticed this myself but this seems to be correct. Thanks.

You can also delete the language line here or I can do it later: https://github.com/laravel/cashier/blob/10.0/resources/lang/en.json#L15

[ralphmorris]

Thanks @driesvints. That's my first (albeit very small) contribution :)

I've just pushed a commit to remove the language line too.