Enabled dynamic loading of Stripe model #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, updated the README to better mach test setup conditions.
taylorotwell
reviewed
Oct 5, 2016
| $model = getenv('STRIPE_MODEL') ?: config('services.stripe.model', 'User'); | ||
| $foreignKey = Str::snake(class_basename($model)).'_id'; |
There was a problem hiding this comment.
Why not create the model instance here and use getForeignKey()?
There was a problem hiding this comment.
This would of course be safer. I made a commit to fix that.
taylorotwell
reviewed
Oct 5, 2016
| @@ -234,7 +234,7 @@ protected function formatAmount($amount) | |||
| public function view(array $data) | |||
| { | |||
| return View::make('cashier::receipt', array_merge( | |||
| $data, ['invoice' => $this, 'user' => $this->user] | |||
| $data, ['invoice' => $this, 'owner' => $this->owner] | |||
There was a problem hiding this comment.
You'll need to still send user to the view as well to not break backwards compatibility.
There was a problem hiding this comment.
You should send both owner and user even though they are the same variable.
There was a problem hiding this comment.
You're right. In case of manual changes to the invoice, developers still referring to the user variable will have issues. Fixed that.
|
Any thoughts on feedback? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pull request related to proposal #334
I know that guidelines dictate that a proposal needs to be approved, but I think this PR will better explain the goal of the proposal.
One of the main changes other than the dynamic loading of the correct model and foreign key based on the configuration, I renamed a variable related to the model from
usertoowner(in lack of a better word).For backward compatibility, the
Subscription::usermethod remains, but utilizesSubscription::owner.Also, updated the README to better match test setup conditions.