[5.7] Update collection every() method documentation #4894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds note to every() method about empty collections.
fixes typo
driesvints
changed the title
|
I'd just like to add that I did some digging and found when this method was introduced which leads to javascript documentation with this behavior and a link to Wikipedia, so I understand why the method works the way it does now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
every()method returns true for empty collections which is not documented but should be, since it goes against what the description would lead most developers to believe. After discussion with a few developers, we decided at least a documentation change should be put in, since changing the behavior may break many apps who rely on this in the wild.