Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.8] Sort helper methods alphabetically #5042

Merged
merged 3 commits into from Mar 6, 2019
Merged

[5.8] Sort helper methods alphabetically #5042

merged 3 commits into from Mar 6, 2019

Conversation

fitztrev
Copy link
Contributor

@fitztrev fitztrev commented Mar 5, 2019

The "Array & Objects" and "Paths" sections are sorted alphabetically, but Strings was not. Also fixed a couple in the other sections.

@imliam
Copy link
Contributor

imliam commented Mar 6, 2019

It would be nice if the actual helper methods on the page were sorted too, not just the list at the top of the page.

@fitztrev
Copy link
Contributor Author

fitztrev commented Mar 6, 2019

If a maintainer tells me it will be accepted, I'll do it. But the diff would look confusing so I didn't do it initially.

@taylorotwell
Copy link
Member

Yeah I agree it would be kinda nice.

@fitztrev
Copy link
Contributor Author

fitztrev commented Mar 6, 2019

Done

@taylorotwell taylorotwell merged commit d1297f4 into laravel:5.8 Mar 6, 2019
@taylorotwell
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants