Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify release note pivot events #5096

Merged
merged 3 commits into from Mar 29, 2019
Merged

Clarify release note pivot events #5096

merged 3 commits into from Mar 29, 2019

Conversation

devcircus
Copy link
Contributor

@devcircus devcircus commented Mar 29, 2019

Issue

In the release notes section, Intermediate Table/Pivot Model Events, the wording was the source of some confusion. An issue was posted on the laravel/framework repo which stated that the user expected there to be new 'syncing', 'detaching', and 'attaching' events available in Laravel 5.8.

Before

In previous versions of Laravel, Eloquent model events were not dispatched when attaching, detaching, or syncing custom intermediate table / "pivot" models of a many-to-many relationship. When using custom intermediate table models in Laravel 5.8, these events will now be dispatched.

Changes

  • A documentation link was added to the reference to "Eloquent model events", to clarify which events will be dispatched.
  • The phrase "these events will now be dispatched" is changed to "the applicable model events will now be dispatched.".

Hopefully these small changes will help clarify this new functionality.

@devcircus devcircus changed the title Reword release note pivot events Clarify release note pivot events Mar 29, 2019
@taylorotwell taylorotwell merged commit 1fa7e29 into laravel:5.8 Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants