Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Fix mobile horizontal scroll on Sanctum page #6726

Closed
wants to merge 1 commit into from

Conversation

timothepearce
Copy link

@timothepearce timothepearce commented Jan 8, 2021

Issue

The current Sanctum page has a horizontal scroll on mobile devices as you can see on the screenshot below:

horizontal-scroll

Fix

I replaced the <code> tag with a <pre> one to avoid the overflow.

@timothepearce timothepearce changed the title [8.x] Fix sanctum mobile horizontal scroll [8.x] Fix mobile horizontal scroll on Sanctum page Jan 8, 2021
@driesvints
Copy link
Member

I'm thinking we should rather fix the breakage itself rather than adjusting the content. Although this is a good intermediary fix.

@timothepearce
Copy link
Author

Thanks, Dries! You're right, I'll make a PR in the website repo.

@timothepearce
Copy link
Author

@driesvints Here is the fix: laravel/laravel.com#153

@timothepearce timothepearce deleted the fix-sanctum-page branch January 8, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants