Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assertAttributeMissing() method #1083

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Add assertAttributeMissing() method #1083

merged 1 commit into from
Feb 2, 2024

Conversation

ziadoz
Copy link
Contributor

@ziadoz ziadoz commented Feb 2, 2024

It would be helpful to have an assertAttributeMissing() method for testing JS attribute toggling behaviour:

Currently you have to assert like this:

$this->assertNull($browser->element('div')->getAttribute('style'));

After this PR it's more succinct:

$this->assertAttributeMissing('div', 'style');

Copy link

github-actions bot commented Feb 2, 2024

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@ziadoz ziadoz marked this pull request as ready for review February 2, 2024 13:02
@taylorotwell taylorotwell merged commit bd1b16c into laravel:7.x Feb 2, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants