[6.x] automatically capture source code on failure #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if an assertion has been made against the source code, capture the source code for analysis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an assertion has been made against the source code, capture the source code for analysis.
In #707 I added the ability to store the source code from the Browser.
#705 was my original attempt where I stored the source code after every test. This was closed with the thought being storing the source for every test was excessive.
This PR finds a good middle ground, and will only automatically store the source on failures where an assertion against the source has been made.
That means either the
assertSourceHas()orassertSourceMissing()assertions must be called for the source to be auto-stored.