Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Name Event #137

Closed
yaien opened this issue Jul 28, 2017 · 3 comments
Closed

Notification Name Event #137

yaien opened this issue Jul 28, 2017 · 3 comments

Comments

@yaien
Copy link

yaien commented Jul 28, 2017

Notification event format actually works on .listen('.Illuminate\\Notifications\\Events\\BroadcastNotificationCreated', console.log);
fix event-format.ts or change notification event to '.Illuminate\\Notifications\\Events\\BroadcastNotificationCreated'

@matrunchyk
Copy link

There is an error in src/util/event-formatter.ts.

There shouldn't be a return there

changing this line to event = event.substr(1); fixes the issue

matrunchyk pushed a commit to matrunchyk/echo that referenced this issue Jul 31, 2017
@ellisio
Copy link
Contributor

ellisio commented Jul 31, 2017

You should be doing the following:

.listen('.Illuminate.Notifications.Events.BroadcastNotificationCreated', console.log);

Out of curiosity, where in the documentation does it say to use the version with slashes? I can't find it.

@ellisio
Copy link
Contributor

ellisio commented Jul 31, 2017

Discussion is in #139 for this issue. Looks like this can be resolved by updating the channel.ts call to the OP's implementation. I miss-read your OP. Sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants