Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requires pusher-js if using socket.io #40

Closed
petecoop opened this issue Sep 7, 2016 · 1 comment
Closed

Requires pusher-js if using socket.io #40

petecoop opened this issue Sep 7, 2016 · 1 comment

Comments

@petecoop
Copy link

petecoop commented Sep 7, 2016

I'm getting Cannot find module 'pusher-js' when packing with browserify and need to require it even when using socket.io.

Could it be moved to outside in a similar way to socket.io? I'd imagine there would be other connectors in the future, and think it would be best if you just install the library for the connector you are using.

@petecoop
Copy link
Author

petecoop commented Sep 8, 2016

As a quick workaround for this I'm using .ignore('pusher-js) in my browserify setup in gulp which just replaces it with an empty object. But would be nice to not have to do this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant