Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] remove pusher and rollup from dependency list #52

Closed
ctf0 opened this issue Sep 22, 2016 · 2 comments
Closed

[Suggestion] remove pusher and rollup from dependency list #52

ctf0 opened this issue Sep 22, 2016 · 2 comments

Comments

@ctf0
Copy link

ctf0 commented Sep 22, 2016

1- for users using socket.io , u still have to install pusher.js or u would get an error #40

ERROR in ./~/laravel-echo/dist/echo.js
Module not found: Error: Can't resolve 'pusher-js'

2- elixir is using webpack which mostly is what users will be using, so no need for rollup

in both cases it should be left to the user to decide which tool he/she will be using.

UPDATE
#110

@ctf0 ctf0 changed the title remove pusher and rollup from dependency list [Suggestion] remove pusher and rollup from dependency list Sep 23, 2016
@seancheung
Copy link

Temporarily you may use webpack config to ignore pusher-js:

Add this file to your project root:

webpack.config.js

var webpack = require("webpack");

module.exports = {
    plugins: [
        new webpack.IgnorePlugin(/pusher-js/),
    ]
}

@AliBoukthir
Copy link

@seancheung thank you so much .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants