Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary fix to allow dot syntax event names. #132

Closed
wants to merge 1 commit into from
Closed

Temporary fix to allow dot syntax event names. #132

wants to merge 1 commit into from

Conversation

ellisio
Copy link
Contributor

@ellisio ellisio commented Jul 25, 2017 •
edited

Please refer to my reasoning here: #119 (comment)

TL;DR Dot syntax server.created is not functioning correctly. This PR adds the option allowDotSyntax, defaulted to false. Set this option to true to allow the dot syntax to work.

Once we can figure out a valid fix, with proper documentation, that can be noted and released alongside Laravel 5.5 with notes in the upgrade guide.

This was referenced Jul 25, 2017
Closed
Closed
@enzonotario enzonotario mentioned this pull request Jul 25, 2017
Closed
@ellisio ellisio deleted the patch-1 branch July 31, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ellisio @taylorotwell