Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket.io enhancements #43

Closed
wants to merge 2 commits into from
Closed

Socket.io enhancements #43

wants to merge 2 commits into from

Conversation

1618033
Copy link

@1618033 1618033 commented Sep 10, 2016

  • Fixed channel namings; private & presence
  • Did necessary changes to support socket.io v1.4.8
  • Enable client to send messages to server (request)

1618033 added 2 commits September 10, 2016 01:42
- Fixed channel namings; private & presence
- Did necessary changes to support socket.io v1.4.8
- Enable client to send messages to server (request)
@tlaverdure
Copy link
Contributor

Since the Laravel Echo Server does not currently support receiving client events I would hold off on this update. I do think that there is a good use case of this though, and pusher does support this: https://pusher.com/docs/client_api_guide/client_events#trigger-events

Would make sense for high capacity collaboration apps that emit a ton of arbitrary input events (mousemove, click, keypress, etc). As this may be up for discussion, I don't want it to slow things down so I've submitted another PR to fix the private and presence prefixes. Laravel Echo Server 1.0 will be out soon.

@1618033
Copy link
Author

1618033 commented Sep 10, 2016

Made a pull request to Laravel Echo Server to support requests from client.

Thanks and regards!

On Sat, Sep 10, 2016 at 11:13 AM, Thiery Laverdure <notifications@github.com

wrote:

Since the Laravel Echo Server does not currently support receiving client
events I would hold off on this update. I do think that there is a good use
case of this though, and pusher does support this:
https://pusher.com/docs/client_api_guide/client_events#trigger-events

Would make sense for high capacity collaboration apps that emit a ton of
arbitrary input events (mousemove, click, keypress, etc). As this may be up
for discussion, I don't want it to slow things down so I've submitted
another PR #44 to fix the private
and presence prefixes. Laravel Echo Server 1.0 will be out soon.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#43 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ASC55JrywlgZx-eVSQW3JpSBh4zhgfhbks5qotdBgaJpZM4J5pyS
.

@taylorotwell
Copy link
Member

Closing for now.

@vesper8
Copy link

vesper8 commented Nov 30, 2016

Would love to see this added to Laravel Echo and Laravel-Echo-Server!

@zdnk
Copy link

zdnk commented Jan 7, 2017

Any update or progress on this? @taylorotwell @1618033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants