[1.x] Only use two factor action when enabled #127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR resolves the issue of validating credentials twice when two-factor is disabled and the default login pipeline is used:
fortify/src/Http/Controllers/AuthenticatedSessionController.php
Lines 83 to 88 in c77b183
Description
When two-factor authentication is disabled via the configuration file, users credentials are still validated twice, even though the action can be bypassed completely and another database call /
$authenticateUsing
callback execution can be avoided.This is due to the
RedirectIfTwoFactorAuthenticatable
action, as well as theAttemptToAuthenticate
action.This was brought to light when overriding the
$authenticateUsing
callback, since it will be called twice, even when two-factor is omitted infeatures
.