[1.x] Fix Two Factor prepare auth session #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just pushed improvements to Fortify's rate limiting setup that handles this. |
|
Sorry wrong PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for #171. After a successful two factor auth, the
PrepareAuthenticatedSessionaction is never reached and thus a new CSRF token is never generated nor is the rate limiter reset. This PR adds these calls manually to theTwoFactorAuthenticatedSessionController. Ideally thePrepareAuthenticatedSessionaction would handle this but it can never be reached because two factor is being done in a new request.There's also a few minor DocBlock fixes I sneaked in.