[1.x] Retrieve user through provider #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorotwell
added a commit
that referenced
this pull request
Jan 7, 2021
This reverts commit f0f8080.
taylorotwell
added a commit
that referenced
this pull request
Jan 7, 2021
mpyw
reviewed
Jun 25, 2022
Comment on lines
+78
to
+88
| $user = $this->guard->getProvider()->retrieveByCredentials( | ||
| $request->only(Fortify::username(), 'password') | ||
| ); | ||
|
|
||
| return tap($model::where(Fortify::username(), $request->{Fortify::username()})->first(), function ($user) use ($request) { | ||
| if (! $user || ! Hash::check($request->password, $user->password)) { | ||
| $this->fireFailedEvent($request, $user); | ||
| if (! $user) { | ||
| $this->fireFailedEvent($request, $user); | ||
|
|
||
| $this->throwFailedAuthenticationException($request); | ||
| } | ||
| }); | ||
| $this->throwFailedAuthenticationException($request); | ||
| } | ||
|
|
||
| return $user; |
There was a problem hiding this comment.
The verification might be not enough. retrieveByCredentials() does not expect password matches, only an email address does. Password hash validation is done by validateCredentials(), but its call was not included in the PR.
I think it is the cause of the PR reverted.
@taylorotwell Is it right?
This was referenced Jun 25, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-send for #180