[1.x] Fix password rule #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonroyage
reviewed
Jan 28, 2021
src/Rules/Password.php
Outdated
| @@ -51,6 +51,8 @@ class Password implements Rule | |||
| */ | |||
| public function passes($attribute, $value) | |||
| { | |||
| $value = is_array($value) ? '' : (string) $value; | |||
There was a problem hiding this comment.
Would it make more sense to flip this to an is_scalar($value) ? (string) $value : '' to also capture any possible scenario where the input is an object, although that wouldn't really happen with validating requests but could happen if someone were to run the Validator manually.
The current approach would also convert any class that has __toString implemented, not sure if you intended it like that?
There was a problem hiding this comment.
Good suggestion, done 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug when a non-string value is password as input for a password. For example, as an array through an API request from a third party.
#209