[1.x] Returns JSON response #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VerifyEmailController only had support for returning a redirect to a page. But when using API to confirm a new user, a JSON reply is expected. Changed the code to support the functionality, that when required the response is in JSON format.
Changed the use order.
Fixed StyleCI issues
|
The user clicks the verification link in their email client and is sent to the page. How would it be triggered for an API request? |
|
By default the link in the email links to the 'default' laravel verification page. But when you use laravel as a backend API with a SPA, it seems weird that the link is sent to a page different from the SPA. By changing the link in the verification email, sending it to the SPA, the SPA can therefor send a verification request, and handle the result. The SPA would require a JSON reply, and not a redirect to another page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VerifyEmailController only had support for returning a redirect to a page. But when using API to confirm a new user, a JSON reply is expected. Changed the code to support the functionality, that when required the response is in JSON format.
Had to remove the return type, to be able to support JSON reply.
If anything can be improved, please be my guest.