Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x] Add 2fa Events #338

Merged
merged 2 commits into from
Jan 7, 2022
Merged

[1.x] Add 2fa Events #338

merged 2 commits into from
Jan 7, 2022

Conversation

joelbutcher
Copy link
Contributor

@driesvints Resolves your comments on #162 here

joelbutcher and others added 2 commits January 7, 2022 14:36
@joelbutcher
[2.x] Events for Two Factor Authentication (laravel#162)
70ea090 
* added events

* dispatch events

* added tests for events

* Style CI fixes

* rename events

* fix usages

(cherry picked from commit 8105a1a)
@danclaytondev
[2.x] Dispatch Event when Two Factor Challenged (laravel#239)
db69348 
* dispatch event when two factor challenged and test

* use statements styleci

(cherry picked from commit b490728)
@driesvints
Copy link
Member

Thanks @joelbutcher

@joelbutcher
Copy link
Contributor Author

joelbutcher commented Jan 7, 2022 •
edited

Just a shame that the commits have [2.x] on them, that could get confusing...

@driesvints
Copy link
Member

driesvints commented Jan 7, 2022 •
edited

You can rewrite them with interactive rebasing (git rebase -i HEAD~2) and then force push.

@driesvints
Copy link
Member

But tbh Taylor will probably squash merge these anyway.

@joelbutcher
Copy link
Contributor Author

You can rewrite them with interactive rebasing (git rebase -I HEAD~2) and then force push.

Useful tip – thanks!

@taylorotwell taylorotwell merged commit a717da4 into laravel:1.x Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@driesvints driesvints driesvints approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joelbutcher @driesvints @taylorotwell @danclaytondev