Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect key for error bag. #360

Merged
merged 3 commits into from
Feb 21, 2022
Merged

Fix incorrect key for error bag. #360

merged 3 commits into from
Feb 21, 2022

Conversation

vaibhavpandeyvpz
Copy link
Contributor

The key for the error bag if 2FA authentication attempt was unsuccessful is incorrectly passed here.

@driesvints
Copy link
Member

Maybe use both to preserve BC

@taylorotwell taylorotwell merged commit 74279f7 into laravel:1.x Feb 21, 2022
@xiCO2k
Copy link
Contributor

xiCO2k commented Mar 16, 2022

This leads to this on laravel/jetstream:

Screen Shot 2022-03-16 at 22 24 53

Any idea on how to solve it, @driesvints?

@driesvints driesvints mentioned this pull request Mar 17, 2022
Merged
@driesvints
Copy link
Member

Thanks @xiCO2k, I'm attempting a PR here: #369

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vaibhavpandeyvpz @driesvints @xiCO2k @taylorotwell