[1.x] Ensures route password.confirm is defined when not using views #368
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #367
If you implement fortify without views, you have to hardcode the
password.confirm
route because no name is defined on thepost
route.fortify/routes/routes.php
Lines 120 to 121 in b2de125
If you have views enabled (
$enableViews = true
), you are saved because aget
route is defined with the same route.fortify/routes/routes.php
Lines 110 to 114 in b2de125
Currently, this forces people using Fortify with a SPA/custom views (
$enableViews = false
), to hardcode thepassword.confirm
route.While this might not be the prettiest fix, it is a fix that will not cause breaking changes for those already using the package.