Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2FA setup key #371

Merged
merged 4 commits into from
Mar 25, 2022
Merged

2FA setup key #371

merged 4 commits into from
Mar 25, 2022

Conversation

ps-sean
Copy link
Contributor

@ps-sean ps-sean commented Mar 18, 2022

  • Added new route & controller to allow users to use setup key when enabling 2FA

This is necessary for jetstream to be able to support showing the setup key when using inertia

* Added new route & controller to allow users to use setup key when enabling 2FA
@magdicom
Copy link

wouldn't be better if the setup key is placed in the same page as the qrcode, maybe below it?

@ps-sean
Copy link
Contributor Author

ps-sean commented Mar 21, 2022

wouldn't be better if the setup key is placed in the same page as the qrcode, maybe below it?

That’s how I’ve done it in Jetstream. This PR is purely for the inertia build as it requires an API endpoint in fortify to pull the key through.

@taylorotwell taylorotwell merged commit 2c5032b into laravel:1.x Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants