Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and use constants for session flashes #409

Merged
merged 3 commits into from
Oct 6, 2022

Conversation

dwightwatson
Copy link
Contributor

This addresses what I brought up in #408 that it's a little awkward having to compare the status flash to hard-coded strings like two-factor-authentication-enabled to appropriately show the correct messaging to the user. This provides constants on Laravel\Fortify\Fortify which provides clarity in end-user code that the expectation is that these flash messages are a result of an interaction with Fortify.

I've intentionally adopted similar naming to that used by the constants in Laravel's PasswordBroker.

@taylorotwell taylorotwell merged commit e594775 into laravel:1.x Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants