Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use current_password rule when changing password #410

Merged
merged 2 commits into from
Oct 13, 2022

Conversation

dwightwatson
Copy link
Contributor

I noticed that what is implemented in the after callback is effectively the current_password rule, so it would be simpler to just use that rule.

The current implementation has to first check if current_password is set - we can skip that now by relying on required.

The only functional difference here is the error message is different when a value for current_password is not provided - the default Laravel error message: The current password field is required..

@dwightwatson dwightwatson changed the title Current password Use current_password rule when changing password Oct 13, 2022
@taylorotwell taylorotwell merged commit 4e1a237 into laravel:1.x Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants