Parameters order with hash_equals #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There're 2 parameters in built-in function hash_equals, the first is "known_string" and second is "user_string". The notes in PHP manual of hash_equals: > It is important to provide the user-supplied string as the second > parameter, rather than the first. Otherwise, there's a question in stackoverflow.com about [Why is order of arguments in PHP's hash_equals() function important](https://stackoverflow.com/questions/27911597/why-is-order-of-arguments-in-phps-hash-equals-function-important) In this commit, it changed paramenter orders for hash_equals, becuase the "user_string" is provided by `$this->route('id')` and `$this->route('hash')`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There're 2 parameters in built-in function hash_equals, the first is "known_string" and second is "user_string".
The notes in PHP manual of hash_equals:
Otherwise, there's a question in stackoverflow.com about Why is order of arguments in PHP's hash_equals() function important
In this commit, it changed parameter orders for hash_equals, because the "user_string" is provided by
$this->route('id')and$this->route('hash').This commit will not break any existing features because it only change the order of
hash_equals().