Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Put length parameter for translation #70

Merged
merged 1 commit into from Sep 21, 2020
Merged

[1.x] Put length parameter for translation #70

merged 1 commit into from Sep 21, 2020

Conversation

Tefoh
Copy link
Contributor

@Tefoh Tefoh commented Sep 20, 2020

put a parameter to detect easily in translation files.
change this:

return __('The :attribute must be at least '.$this->length.' characters and contain at least one uppercase character.');

to:

return __('The :attribute must be at least :length characters and contain at least one uppercase character.', ['length' => $this->length]);

@driesvints driesvints changed the title put length parameter for translation [1.x] Put length parameter for translation Sep 21, 2020
@taylorotwell taylorotwell merged commit 96e6463 into laravel:1.x Sep 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants