[1.x] Fix for empty password during confirmation #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanvanhelden
force-pushed
the
fix-for-empty-password-during-confirmation
branch
from
26f26a7
to
dd63bf5
Compare
|
Does the other method in this class that type hints string password need that same change? |
fix code style
johanvanhelden
force-pushed
the
fix-for-empty-password-during-confirmation
branch
from
a202ef3
to
fef7dea
Compare
|
@taylorotwell Yes, it does! I've added a fix and tests. |
johanvanhelden
deleted the
fix-for-empty-password-during-confirmation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow an empty password to be given and let it behave as an invalid password.
Before this fix, if the user leaves the field empty, a server error would occur. Now, a nice validation error will show.
Fixes #86