fix dynamic component bug

laravel · Sep 9, 2020 · 4b1e317 · 4b1e317
1 parent 75e792d
commit 4b1e317
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/Illuminate/View/DynamicComponent.php b/src/Illuminate/View/DynamicComponent.php
@@ -54,7 +54,7 @@ public function __construct(string $component)
     public function render()
     {
         $template = <<<'EOF'
-<?php extract(collect($attributes->getAttributes())->mapWithKeys(function ($value, $key) { return [Illuminate\Support\Str::camel($key) => $value]; })->all(), EXTR_SKIP); ?>
+<?php extract(collect($attributes->getAttributes())->mapWithKeys(function ($value, $key) { return [Illuminate\Support\Str::camel(str_replace(':', ' ', $key)) => $value]; })->all(), EXTR_SKIP); ?>
 {{ props }}
 <x-{{ component }} {{ bindings }} {{ attributes }}>
 {{ slots }}
@@ -113,7 +113,7 @@ protected function compileProps(array $bindings)
     protected function compileBindings(array $bindings)
     {
         return collect($bindings)->map(function ($key) {
-            return ':'.$key.'="$'.Str::camel($key).'"';
+            return ':'.$key.'="$'.Str::camel(str_replace(':', ' ', $key)).'"';
         })->implode(' ');
     }
 

diff --git a/tests/Integration/View/BladeTest.php b/tests/Integration/View/BladeTest.php
@@ -30,7 +30,7 @@ public function test_rendering_a_dynamic_component()
     {
         $view = View::make('uses-panel-dynamically', ['name' => 'Taylor'])->render();
 
-        $this->assertEquals('<div class="ml-2">
+        $this->assertEquals('<div class="ml-2" wire:model="foo">
     Hello Taylor
 </div>', trim($view));
     }

diff --git a/tests/Integration/View/templates/uses-panel-dynamically.blade.php b/tests/Integration/View/templates/uses-panel-dynamically.blade.php
@@ -1,3 +1,3 @@
-<x-dynamic-component component="panel" class="ml-2" :name="$name">
+<x-dynamic-component component="panel" class="ml-2" :name="$name" wire:model="foo">
     Panel contents
 </x-dynamic-component>