Add test for the assertHeaderMissing response assertion (#22866)

laravel · Jan 20, 2018 · 4bcffd4 · 4bcffd4
1 parent cd4029f
commit 4bcffd4
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/Illuminate/Foundation/Testing/TestResponse.php b/src/Illuminate/Foundation/Testing/TestResponse.php
@@ -131,7 +131,7 @@ public function assertHeader($headerName, $value = null)
      * @param  string  $headerName
      * @return $this
      */
-    protected function assertHeaderMissing($headerName)
+    public function assertHeaderMissing($headerName)
     {
         PHPUnit::assertFalse(
             $this->headers->has($headerName), "Unexpected header [{$headerName}] is present on response."

diff --git a/tests/Foundation/FoundationTestResponseTest.php b/tests/Foundation/FoundationTestResponseTest.php
@@ -70,6 +70,24 @@ public function testAssertHeader()
         }
     }
 
+    public function testAssertHeaderMissing()
+    {
+        $baseResponse = tap(new Response, function ($response) {
+            $response->header('Location', '/foo');
+        });
+
+        $response = TestResponse::fromBaseResponse($baseResponse);
+
+        try {
+            $response->assertHeaderMissing('Location');
+        } catch (\PHPUnit\Framework\ExpectationFailedException $e) {
+            $this->assertContains(
+                'Unexpected header [Location] is present on response.',
+                $e->getMessage()
+            );
+        }
+    }
+
     public function testAssertJsonWithArray()
     {
         $response = TestResponse::fromBaseResponse(new Response(new JsonSerializableSingleResourceStub));