Skip to content

Commit

Permalink
Remove annotation support.
Browse files Browse the repository at this point in the history
This will be taken over as a 3rd party package. @artisangoose has
volunteered.
  • Loading branch information
taylorotwell committed Jan 6, 2015
1 parent 8e80fd5 commit 4d9f92e
Show file tree
Hide file tree
Showing 33 changed files with 2 additions and 1,858 deletions.
1 change: 0 additions & 1 deletion composer.json
Expand Up @@ -17,7 +17,6 @@
"classpreloader/classpreloader": "~1.0.2",
"danielstjules/stringy": "~1.5",
"d11wtq/boris": "~1.0",
"doctrine/annotations": "~1.0",
"doctrine/inflector": "~1.0",
"ircmaxell/password-compat": "~1.0",
"jeremeamia/superclosure": "~1.0.1",
Expand Down
26 changes: 0 additions & 26 deletions src/Illuminate/Events/Annotations/Annotations/Hears.php

This file was deleted.

120 changes: 0 additions & 120 deletions src/Illuminate/Events/Annotations/Scanner.php

This file was deleted.

40 changes: 0 additions & 40 deletions src/Illuminate/Foundation/Application.php
Expand Up @@ -629,46 +629,6 @@ public function getCachedRoutesPath()
return $this['path.storage'].'/framework/routes.php';
}

/**
* Determine if the application routes have been scanned.
*
* @return bool
*/
public function routesAreScanned()
{
return $this['files']->exists($this->getScannedRoutesPath());
}

/**
* Get the path to the scanned routes file.
*
* @return string
*/
public function getScannedRoutesPath()
{
return $this['path.storage'].'/framework/routes.scanned.php';
}

/**
* Determine if the application events have been scanned.
*
* @return bool
*/
public function eventsAreScanned()
{
return $this['files']->exists($this->getScannedEventsPath());
}

/**
* Get the path to the scanned events file.
*
* @return string
*/
public function getScannedEventsPath()
{
return $this['path.storage'].'/framework/events.scanned.php';
}

/**
* Call the booting callbacks for the application.
*
Expand Down
92 changes: 0 additions & 92 deletions src/Illuminate/Foundation/Console/EventScanCommand.php

This file was deleted.

99 changes: 0 additions & 99 deletions src/Illuminate/Foundation/Console/RouteScanCommand.php

This file was deleted.

23 comments on commit 4d9f92e

@KennedyTedesco
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! πŸ‘

Sorry about that, but:

image

@opb
Copy link

@opb opb commented on 4d9f92e Jan 6, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem did you have?

@KennedyTedesco
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now Taylor has one less problem to maintain. πŸ˜„

@abstractFlo
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the annotation support aborted? I love this function :(

@taylorotwell
Copy link
Member Author

@taylorotwell taylorotwell commented on 4d9f92e Jan 7, 2015 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanpmartins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but this really sucks. In my opinion was a great core tool. To much rubbish noise on the community about route annotations. Please let us know more about this new package.
πŸ‘Ž

@hivoid
Copy link

@hivoid hivoid commented on 4d9f92e Jan 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘
πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘ πŸ‘

@megaleecher
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it was a great feature too... Only have the option to use on single routes.php files makes this files cramped very quickly. I think it is very hard to maintain this single file... Having annotation gives us the possibility to extract the routes to the controller and see what route points to a single method without the need to open a seperate file.

As long as no one is forced to use annotations its on everybodies own.

@crynobone
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonathanpmartins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, very helpful! πŸ‘

@ralf57
Copy link

@ralf57 ralf57 commented on 4d9f92e Jan 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me too, I've never been excited by annotations but this feature add/remove (and related blog posts and laracasts) indicates a somehow schizophrenic (no offence, eh) development

@mhriemers
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was confused as to why my gulp watch was still running without errors but no routes file was being created. This was the reason :)

A shame to see the feature go but I guess it was necessary.

@qufo
Copy link

@qufo qufo commented on 4d9f92e Jan 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job. πŸ‘

@Garbee
Copy link
Contributor

@Garbee Garbee commented on 4d9f92e Jan 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@megaleecher You can actually create multiple route files to break things up in. Like a "frontend", "admin", and "api" specific routes file and just call them all into the service provider. Or if you want to really up your game, don't use route files at all. Just declare your routes right in the service provider (and create multiple ones to keep things smaller.) Then you can also separate things in sections by using different methods.

Many ways to keep routes cleaner, annotations not necessarily needed unless it is a style you liked (which the package is available for.)

@hackel
Copy link
Contributor

@hackel hackel commented on 4d9f92e Jan 7, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the spam, but a big thank you to @artisangoose for making it so easy to fix this (and doing it so quickly!).

@jonathanpmartins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result of this decision resulted in this package being maintained by a huge fan of Laravel Annotations.
From fan to fans! hehehehe

@ahmadina
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why ?? : ((

@jonathanpmartins
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmadina Look here: https://github.com/adamgoose/laravel-annotations
Very simple to integrate!

@marvin-w
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this has become THE most said sentence since the announcement of Laravel 5.

Ohh this and that ---> very simple to integrate, but was dropped of the core...

@jlem
Copy link

@jlem jlem commented on 4d9f92e Jan 8, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. Annotations are an awkward, un-intuitive anti-pattern piggybacked into the core language as a 3rd party pseudo-language, and a silly abuse of reflection. Annotations that affect 3rd party code generation tools are fine (PHPDocumentor etc), but annotations that affect code execution is abuse.

Anyone who criticized facades as being a lazy shortcut and bad practice, and then happily use annotations like there's nothing wrong with a 3rd party syntax in comments affecting code execution, are hypocrites (looking at you Symfony...............)

@RomainLanz
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@jlem Totally agree with you

@jbruni
Copy link
Contributor

@jbruni jbruni commented on 4d9f92e May 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ Oh! What a relief! Laravel didn't lose its way!

@maveius
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘Ž The best feature was removed from Laravel 5.0 ;( I' am very sad.

Please merge it to laravel 6.0 ?
Project https://github.com/adamgoose/laravel-annotations is deprecated ? πŸ‘Ž Why?
But https://github.com/LaravelCollective/annotations is not deprecated πŸ‘ Juuupiii !
and i like this : http://laravelcollective.com/ πŸ‘

Please sign in to comment.