Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This will be taken over as a 3rd party package. @artisangoose has volunteered.
- Loading branch information
1 parent
8e80fd5
commit 4d9f92e
Showing
33 changed files
with
2 additions
and
1,858 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! π
Sorry about that, but:
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What problem did you have?
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now Taylor has one less problem to maintain. π
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the annotation support aborted? I love this function :(
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but this really sucks. In my opinion was a great core tool. To much rubbish noise on the community about route annotations. Please let us know more about this new package.
π
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π π π π π π π π
π π π π π π π π
π π π π π π π π
π π π π π π π π
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me it was a great feature too... Only have the option to use on single routes.php files makes this files cramped very quickly. I think it is very hard to maintain this single file... Having annotation gives us the possibility to extract the routes to the controller and see what route points to a single method without the need to open a seperate file.
As long as no one is forced to use annotations its on everybodies own.
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just grab the new package https://github.com/adamgoose/laravel-annotations
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, very helpful! π
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Me too, I've never been excited by annotations but this feature add/remove (and related blog posts and laracasts) indicates a somehow schizophrenic (no offence, eh) development
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was confused as to why my gulp watch was still running without errors but no routes file was being created. This was the reason :)
A shame to see the feature go but I guess it was necessary.
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice Job. π
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@megaleecher You can actually create multiple route files to break things up in. Like a "frontend", "admin", and "api" specific routes file and just call them all into the service provider. Or if you want to really up your game, don't use route files at all. Just declare your routes right in the service provider (and create multiple ones to keep things smaller.) Then you can also separate things in sections by using different methods.
Many ways to keep routes cleaner, annotations not necessarily needed unless it is a style you liked (which the package is available for.)
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the spam, but a big thank you to @artisangoose for making it so easy to fix this (and doing it so quickly!).
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The result of this decision resulted in this package being maintained by a huge fan of Laravel Annotations.
From fan to fans! hehehehe
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why ?? : ((
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahmadina Look here: https://github.com/adamgoose/laravel-annotations
Very simple to integrate!
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this has become THE most said sentence since the announcement of Laravel 5.
Ohh this and that ---> very simple to integrate, but was dropped of the core...
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Annotations are an awkward, un-intuitive anti-pattern piggybacked into the core language as a 3rd party pseudo-language, and a silly abuse of reflection. Annotations that affect 3rd party code generation tools are fine (PHPDocumentor etc), but annotations that affect code execution is abuse.
Anyone who criticized facades as being a lazy shortcut and bad practice, and then happily use annotations like there's nothing wrong with a 3rd party syntax in comments affecting code execution, are hypocrites (looking at you Symfony...............)
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
@jlem Totally agree with you
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π Oh! What a relief! Laravel didn't lose its way!
4d9f92e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π The best feature was removed from Laravel 5.0 ;( I' am very sad.
Please merge it to laravel 6.0 ?
Project https://github.com/adamgoose/laravel-annotations is deprecated ? π Why?
But https://github.com/LaravelCollective/annotations is not deprecated π Juuupiii !
and i like this : http://laravelcollective.com/ π