Invert the firstOrNew if statement

laravel · Sep 26, 2023 · 8a2ca69 · 8a2ca69
1 parent 66d1109
commit 8a2ca69
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php b/src/Illuminate/Database/Eloquent/Relations/HasManyThrough.php
@@ -256,11 +256,11 @@ protected function buildDictionary(Collection $results)
      */
     public function firstOrNew(array $attributes = [], array $values = [])
     {
-        if (is_null($instance = $this->where($attributes)->first())) {
-            $instance = $this->related->newInstance(array_merge($attributes, $values));
+        if (! is_null($instance = $this->where($attributes)->first())) {
+            return $instance;
         }
 
-        return $instance;
+        return $this->related->newInstance(array_merge($attributes, $values));
     }
 
     /**