Merge pull request #13025 from themsaid/validator-dependents

[5.2] Add after and before to dependent rules array
laravel · Apr 6, 2016 · d30ff2b · d30ff2b
2 parents 8495627 + 2e0dd6a
commit d30ff2b
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 0 deletions.
diff --git a/src/Illuminate/Validation/Validator.php b/src/Illuminate/Validation/Validator.php
@@ -174,6 +174,7 @@ class Validator implements ValidatorContract
     protected $dependentRules = [
         'RequiredWith', 'RequiredWithAll', 'RequiredWithout', 'RequiredWithoutAll',
         'RequiredIf', 'RequiredUnless', 'Confirmed', 'Same', 'Different', 'Unique',
+        'Before', 'After',
     ];
 
     /**

diff --git a/tests/Validation/ValidationValidatorTest.php b/tests/Validation/ValidationValidatorTest.php
@@ -2647,6 +2647,31 @@ public function testValidateImplicitEachWithAsterisksRequiredWithoutAll()
         $this->assertTrue($v->messages()->has('foo.0.bar.1.name'));
     }
 
+    public function testValidateImplicitEachWithAsterisksBeforeAndAfter()
+    {
+        $trans = $this->getRealTranslator();
+
+        $v = new Validator($trans, ['foo' => [
+            ['start' => '2016-04-19', 'end' => '2046-04-19'],
+        ]], ['foo.*.start' => ['before:foo.*.end']]);
+        $this->assertTrue($v->passes());
+
+        $v = new Validator($trans, ['foo' => [
+            ['start' => '2016-04-19', 'end' => '2046-04-19'],
+        ]], ['foo.*.end' => ['before:foo.*.start']]);
+        $this->assertTrue($v->fails());
+
+        $v = new Validator($trans, ['foo' => [
+            ['start' => '2016-04-19', 'end' => '2046-04-19'],
+        ]], ['foo.*.end' => ['after:foo.*.start']]);
+        $this->assertTrue($v->passes());
+
+        $v = new Validator($trans, ['foo' => [
+            ['start' => '2016-04-19', 'end' => '2046-04-19'],
+        ]], ['foo.*.start' => ['after:foo.*.end']]);
+        $this->assertTrue($v->fails());
+    }
+
     public function testValidateEachWithNonIndexedArray()
     {
         $trans = $this->getRealTranslator();