[5.3] [database] Fix misleading error message on wrong DB credentials, when Exception Handler is not bound in container

[foglcz]

• Laravel Version: 5.3
• PHP Version: n/a
• Database Driver & Version: n/a
• Pull request: [5.3] Fix misleading exception when ExceptionHandler is not bound #16666

Description:

When using Illuminate\Database out of framework (= dependant libraries, demo files, showcases), and credentials are not valid, Capsule will report:

Uncaught Illuminate\Contracts\Container\BindingResolutionException:
    Target [Illuminate\Contracts\Debug\ExceptionHandler] is not instantiable.

When the correct exception should be

Uncaught PDOException: SQLSTATE[HY000] [1045] Access denied for user
    'wrong_username'@'localhost' (using password: YES)

Steps To Reproduce:

// demo.php
require __DIR__ . '/vendor/autoload.php';
$capsule = new Illuminate\Database\Capsule\Manager();
$capsule->addConnection([
    'driver'    => 'mysql',
    'host'      => 'localhost',
    'database'  => 'some_database',
    'username'  => 'wrong_username',
    'password'  => 'wrong_password',
    'charset'   => 'utf8',
]);

// Due to lazy loading (kudos!), we actually have to execute something:
$connection = $capsule->getConnection(); 
$connection->table('some_table')->first();

Current result:

PHP Fatal error:  Uncaught Illuminate\Contracts\Container\BindingResolutionException: Target [Illuminate\Contracts\Debug\ExceptionHandler] is not instantiable. in /var/www/github/database/vendor/illuminate/container/Container.php:763

Stack trace:
#0 /var/www/github/database/vendor/illuminate/container/Container.php(644): Illuminate\Container\Container->build('Illuminate\\Cont...', Array)
#1 /var/www/github/database/Connectors/ConnectionFactory.php(129): Illuminate\Container\Container->make('Illuminate\\Cont...')
#2 [internal function]: Illuminate\Database\Connectors\ConnectionFactory->Illuminate\Database\Connectors\{closure}()
#3 /var/www/github/database/Connection.php(965): call_user_func(Object(Closure))
#4 /var/www/github/database/Connection.php(986): Illuminate\Database\Connection->getPdo()
#5 /var/www/github/database/Connection.php(423): Illuminate\Database\Connection->getReadPdo()
#6 /var/www/github/database/Connection.php(333): Illuminate\Database\Connection->getPdoForSelect(true)
#7 /var/www/github/database/Connection. in /var/www/github/database/Connection.php on line 770

Result after fix is applied:

Fatal error: Uncaught PDOException: SQLSTATE[HY000] [1045] Access denied for user 'wrong_username'@'localhost' (using password: YES) in /var/www/github/database/Connectors/Connector.php:119

Stack trace:
#0 /var/www/github/database/Connectors/Connector.php(119): PDO->__construct('mysql:host=loca...', 'wrong_username', 'wrong_password', Array)
#1 /var/www/github/database/Connectors/Connector.php(56): Illuminate\Database\Connectors\Connector->createPdoConnection('mysql:host=loca...', 'wrong_username', 'wrong_password', Array)
#2 /var/www/github/database/Connectors/MySqlConnector.php(24): Illuminate\Database\Connectors\Connector->createConnection('mysql:host=loca...', Array, Array)
#3 /var/www/github/database/Connectors/ConnectionFactory.php(126): Illuminate\Database\Connectors\MySqlConnector->connect(Array)
#4 [internal function]: Illuminate\Database\Connectors\ConnectionFactory->Illuminate\Database\Connectors\{closure}()
#5 /var/www/github/database/Connection.php(965): call_user_func(Object(Closure))
#6 /var/www/github/data in /var/www/github/database/Connection.php on line 770