Database independent PDO checks

[Silic0nS0ldier]

Currently there is code intended to trigger a PDOException on database connection failure, due to built in library throwing a useless exception that makes debugging next to impossible.

However this check is specific to MySQL (and by extension MariaDB) as PDO expects different keywords for different database systems.

This check should be refactored into a class that mimics the behaviour of Laravels library, or a fix should be made to their code so that a more debugable exception is thrown. (assuming their latest version isn't above our minimum PHP requirement, it shouldn't be from memory)

[alexweissman]

So, I just discovered this commit to illuminate/database 5.3: laravel/framework#16666

Which references this issue: laravel/framework#16661

Notice that this fix happened only two days after I implemented our own check!.

So, if I'm understanding this correctly, I think we can completely remove our database check, and just let Laravel throw the actual PDOException now if the connection fails.

[lcharette]

I guess it's fixed too in 5.4 ?

Yes it is : https://github.com/laravel/framework/blob/5.4/src/Illuminate/Database/Connectors/ConnectionFactory.php#L185

[alexweissman]

So, I think we can just remove the check from Authenticator completely, and use getPdo() to test the connection in the installer now.

[alexweissman]

Alright, implemented in 9c9316b.