Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments are not forward engineered to columns in postgres schema #23012

Closed
phpguru opened this issue Feb 2, 2018 · 1 comment
Closed

Comments are not forward engineered to columns in postgres schema #23012

phpguru opened this issue Feb 2, 2018 · 1 comment

Comments

@phpguru
Copy link
Contributor

phpguru commented Feb 2, 2018

  • Laravel Version: 5.5.32
  • PHP Version: 7.1.11
  • Database Driver & Version: pdo, pdo_postgres
    PostgreSQL 10.1 on x86_64-pc-linux-gnu, compiled by gcc (Debian 6.3.0-18) 6.3.0 20170516, 64-bit

Description:

After running the following migration against Postgres database in Docker container:

public function up()
{
    Schema::create('sample', function (Blueprint $table) {
        $table->increments('id')->comment('primary key');
        $table->timestamps();
    });
}

I could be doing something wrong, but it appears the comment is not created in the schema.

The SQL that needs to happen is [1]

COMMENT ON COLUMN sample.id IS 'primary key'; 

Steps To Reproduce:

Try migrating against postgres with a column comment.

If this is indeed a bug, if you can point me to the point in the code where this ought to happen I would be happy to attempt a PR for it.

[1] https://www.postgresql.org/docs/9.1/static/sql-comment.html

@mfn
Copy link
Contributor

mfn commented Feb 3, 2018

Already fixed in 5.6 via #21855

@themsaid themsaid closed this as completed Feb 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants