Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.6] Postgres add comment (#18782) #21855

Merged
merged 2 commits into from
Oct 31, 2017
Merged

[5.6] Postgres add comment (#18782) #21855

merged 2 commits into from
Oct 31, 2017

Conversation

andersondanilo
Copy link
Contributor

@andersondanilo andersondanilo commented Oct 28, 2017 •
edited
Loading

@GrahamCampbell GrahamCampbell changed the title Postgres add comment (#18782) [5.5] Postgres add comment (#18782) Oct 28, 2017
@Dylan-DPC-zz
Copy link

This is a breaking change.

@GrahamCampbell GrahamCampbell changed the base branch from 5.5 to master October 29, 2017 10:31
@GrahamCampbell GrahamCampbell changed the title [5.5] Postgres add comment (#18782) [5.6] Postgres add comment (#18782) Oct 29, 2017
@dmitryuk
Copy link
Contributor

usefull commit

@taylorotwell
Copy link
Member

Why not implement it like the MySQL grammar?

@andersondanilo
Copy link
Contributor Author

Hi @taylorotwell,

I tried to imitate MySql, but in postgres the comment is added in another statement, not as a "modifier"

@taylorotwell taylorotwell merged commit 35d37f0 into laravel:master Oct 31, 2017
@mfn mfn mentioned this pull request Dec 16, 2017
Merged
@mfn mfn mentioned this pull request Feb 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@andersondanilo @Dylan-DPC-zz @dmitryuk @taylorotwell