Skip to content

[5.6] Postgres add comment (#18782)#21855

Merged
taylorotwell merged 2 commits intolaravel:masterfrom
andersondanilo:5.5
Oct 31, 2017
Merged

[5.6] Postgres add comment (#18782)#21855
taylorotwell merged 2 commits intolaravel:masterfrom
andersondanilo:5.5

Conversation

@andersondanilo
Copy link
Copy Markdown
Contributor

@andersondanilo andersondanilo commented Oct 28, 2017

@GrahamCampbell GrahamCampbell changed the title Postgres add comment (#18782) [5.5] Postgres add comment (#18782) Oct 28, 2017
@Dylan-DPC-zz
Copy link
Copy Markdown

This is a breaking change.

@GrahamCampbell GrahamCampbell changed the base branch from 5.5 to master October 29, 2017 10:31
@GrahamCampbell GrahamCampbell changed the title [5.5] Postgres add comment (#18782) [5.6] Postgres add comment (#18782) Oct 29, 2017
@dmitryuk
Copy link
Copy Markdown
Contributor

usefull commit

@taylorotwell
Copy link
Copy Markdown
Member

Why not implement it like the MySQL grammar?

@andersondanilo
Copy link
Copy Markdown
Contributor Author

Hi @taylorotwell,

I tried to imitate MySql, but in postgres the comment is added in another statement, not as a "modifier"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants