New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Verification invalid Domain in Email #26246
Comments
What's the actual value of |
Got the same problem when sending mail notification: Notification::route('mail', 'xxx@gmail.com')->notify(new App\Notifications\InvoiceOrder($sc)); |
|
The problem is that |
That’s true. The bug is not that the email will not be sent.
The bug is how Laravel handles this. Laravel will show the 500 page because the exception thrown by swift mailer is unhandled. This is not really helpful for the user... There should be a validation error like message which tells the user that an invalid email was entered.
… Am 30.10.2018 um 19:17 schrieb Yohanan Baruchel ***@***.***>:
The problem is that hallotim.de is not a registered domain so you can't send an email to this address.. I don't think it's a bug.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sounds to me that this is more a user land error than an actual problem with the framework. You can catch the |
It looks like I do have the same issue, even with try{}catch(Swift_TransportException $sft){} the exception is not handled and it crashes. |
My mailer doesn't throw an error immediately, as the relay accepts the outgoing address but then bounces it unless it is a local email, this is because the outgoing mailer tries the lookup, the address given, double bounces and returns to the postmaster for non-delivery notification. This is again why I put a box in the login if someone is awaiting verification, but hasn't clicked on the email, and logins, I return them to the login with a flash notification of the previous email, that the server will resend, and included now with the login and password, is a new email box, which upon correctly entering login and password and new email, a new verification email is sent and the email is updated. I also handle the mailer exception if one is thrown on the registration page. |
@driesvints Could you please reopen this issue? The problem also seems to affect others and has been prematurely closed. |
The requirement for the issue is parable 5.7.9 or higher... Have you guys seen this New email validation mechanism for laravel >=5.8. Seems they have added a new class to the auth folder that standardizes a way to do this, and have included a new view type blade template for the mail, as well as having included it as a contract in the app\user model I still like my very inconvenient reminder of the email address that is unverified by flash message, and including a "wrong email?" button next to the forgot password button, that opens an input field nezt to the username/pw boxes for the new email, and upon validation of user/PS the new email is stored and validation resent to the new address. |
@rip057 It doesn't matter since in some case the mail server will return an error if the e-mail address is misspelled even if the e-mail address specified looks correct and respects standards. The error thrown by this, can't be handled. That's the issue, at least for me. |
We don't consider this a bug. If we catch the exception ourselves and handle it then people who would want to handle it differently are left in the dark. You're free to handle the exception how you want to yourself. |
I am getting the same
error on 5.8 version.
and that changed to
All fine now. |
Hello I have the same problem. All is correct but I receive this message. I don't known why Swift_TransportException |
@ltphen Have you solved the problem? It's the same for me. E-mail sending works. But if the recipient's address is wrong (but valid) this error will be displayed. |
Sorry Wolfgang, I don't use the forum any more and have forgotten what it was about.
If it is critical for you please send me the details and the link to my post (the forum's search does not help much)
Greetings
Richard
Gesendet: Montag, 27. April 2020 um 13:13 Uhr
Von: "Wolfgang Hollaus" <notifications@github.com>
An: "laravel/framework" <framework@noreply.github.com>
Cc: "Caribation Labs" <iteam@gmx.com>, "Comment" <comment@noreply.github.com>
Betreff: Re: [laravel/framework] Email Verification invalid Domain in Email (#26246)
@ltphen Have you solved the problem? It's the same for me. E-mail sending works. But if the recipient's address is wrong (but valid) this error will be displayed.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Description:
If email verification is enabled, the site breaks if an email with a none registered domain is entered.
You could overwrite the
sendEmailVerificationNotification
method and wrap the everything within a try catch block.But then it happens that the user is stuck into an endless loop where the user receives a massage that the email should be verified after login. But the user can't, because the email ist not send due to for example a typo the user made.
It is not even possible to redirect the user to another page since
sendEmailVerificationNotification()
is called after the user has been registered through theIlluminate\Auth\Events\Registered
event.Does someone have a workaround for this issue?
Steps To Reproduce:
https://DOMAIN.TLD/register
tim@hallotim.de
but you made a misstake and typetim@hellotim.de
as E-Mail address (this domain is not registered).The text was updated successfully, but these errors were encountered: