afterCommit() callbacks do not fire when RefreshDatabase handles multiple $connectionsToTransact

[mpyw]

Laravel Version

10.24.0

PHP Version

irrelevant

Database Driver & Version

irrelevant

Description

When multiple connections are specified in $connectionsToTransact (default value: [null]), any callback functions specified in DB::afterCommit() will not be executed.

Steps To Reproduce

<?php

namespace Tests\Feature;

use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Facades\DB;
use Tests\TestCase;

class ExampleTest extends TestCase
{
    protected $connectionsToTransact = [null, 'sqlite'];

    use RefreshDatabase;

    public function testExample(): void
    {
        $executed = false;

        DB::transaction(function () use (&$executed) {
            DB::afterCommit(function () use (&$executed) {
                $executed = true;
            });
        });

        $this->assertTrue($executed);
    }
}

[mpyw]

The timing of callback execution looks to be unclear.

• Without RefreshDatabase, it depends on $transactions === 0 for each connection
• With RefreshDatabase, the decision may be made over multiple connections

[github-actions]

Thank you for reporting this issue!

As Laravel is an open source project, we rely on the community to help us diagnose and fix issues as it is not possible to research and fix every issue reported to us via GitHub.

If possible, please make a pull request fixing the issue you have described, along with corresponding tests. All pull requests are promptly reviewed by the Laravel team.

Thank you!

[mpyw]

@tonysm Does #48466 also fix #48472?

[tonysm]

It should, yeah

[tonysm]

Wait, not sure. You mentio multiple connections, I haven't tested that.

[mpyw]

Looks to be fixed by #48523

@crynobone Thanks!