Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename selectRaw to addSelectRaw #8160

Closed
malhal opened this issue Mar 26, 2015 · 1 comment
Closed

Rename selectRaw to addSelectRaw #8160

malhal opened this issue Mar 26, 2015 · 1 comment

Comments

@malhal
Copy link
Contributor

malhal commented Mar 26, 2015

In Query Builder, the select method clears any previous selects and addSelect appends a select without clearing. Since selectRaw does not clear any previous selects I believe it would be more consistent to rename it addSelectRaw.
@GrahamCampbell
Copy link
Member

We're open to pulls to 5.1. :)

@malhal malhal mentioned this issue Oct 7, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@malhal @GrahamCampbell