Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Fix a case with parameters of explicit depending rules #13058

Merged
merged 1 commit into from
Apr 7, 2016
Merged

[5.2] Fix a case with parameters of explicit depending rules #13058

merged 1 commit into from
Apr 7, 2016

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Apr 7, 2016

As noted in #13047

This PR handles explicit depending rules when the explicit keys are non-numeric:

Validator::make(
    [
        'fields' => [
            'fr' => ['name' => '', 'content' => 'ragnar'],
            'es' => ['name' => '', 'content' => 'lagertha'],
        ]
    ],
    ['fields.*.name' => 'required_with:fields.*.content']
);

Before, it was only working with numeric keys [0, 1] rather than string keys ['fr', 'es'].

@taylorotwell taylorotwell merged commit de872dc into laravel:5.2 Apr 7, 2016
@themsaid themsaid deleted the explicit-params-non-numeric-keys branch April 21, 2016 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants