[5.2] Work around lack of lastInsertId() for ODBC with PDO for MSSQL #13423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
| @@ -3,6 +3,7 @@ | |||
| namespace Illuminate\Database\Query\Processors; | |||
|
|
|||
| use Illuminate\Database\Query\Builder; | |||
| use Exception; | |||
There was a problem hiding this comment.
please order these by length
There was a problem hiding this comment.
Shortest first?
|
Refs #14121 which brings 2 fixes for this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the ODBC driver for MSSQL an exception is thrown because the PDO driver does not implement lastInsertId().
This works around that by making an SQL call to return the id when using ODBC.