[5.2] Fix morphTo macro calls #13828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Replay stored macro calls on the actual related instance. | ||
| * | ||
| * @param Builder $query |
|
@dwightwatson glad that it works for you. What we had before was actually a hack that only handled |
|
Does this bug apply to any other relationships or just MorphTo? |
|
Seems to be working on other relationships to me. We use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes another edge case, where we want to call a query macro (like
withTrashed,onlyTrashed) on amorphTorelation, but the macro only exists on the related model.Before we had a hack that only handled
withTrashedcalls (https://github.com/laravel/framework/blob/5.1/src/Illuminate/Database/Eloquent/Relations/MorphTo.php#L240:L267) now I generalized the idea, so that all macro calls are captured and replayed when we have an actual related instance.