[5.2] Allow the detach method to accept a collection #14412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamCampbell
changed the title
|
The fact you changed the method signature (event just the phpdoc) means this is probably better targeted at L5.3. |
| * @param bool $touch | ||
| * @return int | ||
| */ | ||
| public function detach($ids = [], $touch = true) | ||
| { | ||
| if ($ids instanceof Model) { | ||
| $ids = (array) $ids->getKey(); | ||
| $ids = $ids->getKey(); |
There was a problem hiding this comment.
Why is this no longer an array?
|
This behaviour already exists for attach. The id var isn't been casted 3 times either haha. Can go for 5.3 if you really think so. Cherry pick this commit and submit pull request again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says!