Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Allowing unversioned assets with elixir function #14987

Merged
merged 1 commit into from
Aug 24, 2016
Merged

[5.3] Allowing unversioned assets with elixir function #14987

merged 1 commit into from
Aug 24, 2016

Conversation

assertchris
Copy link
Contributor

@assertchris assertchris commented Aug 24, 2016

Currently, when you have a file myapp/public/css/app.css, and use {{ elixir('css/app.css') }}, you will get an InvalidArgumentException, unless you also have mix.versioned('css/app.css').

This change allows elixir() to return paths to existing files, preferring to get them out of the manifest.

@GrahamCampbell GrahamCampbell changed the title Allowing unversioned assets with elixir function [5.3] Allowing unversioned assets with elixir function Aug 24, 2016
@taylorotwell taylorotwell merged commit d7303d9 into laravel:5.3 Aug 24, 2016
@assertchris
Copy link
Contributor Author

assertchris commented Aug 24, 2016

I was watching this as you hit the merge button! My brain just wobbled in my head...

@piotr-cz
Copy link

You should also change InvalidException message to something like "File {$file} does not exist.", since now it's thrown not when $file is not present in asset manifest (it's not obligatory), but when it doesn't exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants